(Programming Q) Generating receive addresses from p2wsh multi-sig script?

I'm learning how BTC works by writing a wallet.

The simplified code I got is:

import hashlib
from embit import bech32
from binascii import b2a_base64, a2b_base64, hexlify, unhexlify

# List of sorted xpubs
sorted_xpubs = [
    '02b713cc0d0fca02323d96e6538528215ca67b128ecdac4a56a43ac45ad937e988',
    '038b00eba3c048cb9bd5e9d6d25065d2c86cfb45fe86f0c0f4093ccaf60a41234c',
    '03b7a5fcf032765bf0b35e51c4974df0bbed8d099b79e8b15d293b876371906cf9'
]

# Function to create the witness script (sorted multi-sig 2-of-3)
def create_witness_script(sorted_xpubs):
    # Convert sorted_xpubs to public keys (for simplicity using the raw sorted_xpubs here)
    pubkeys = [bytes.fromhex(xpub) for xpub in sorted_xpubs]

    # Construct the witness script: OP_2 <pubkey1> <pubkey2> <pubkey3> OP_3 OP_CHECKMULTISIG
    witness_script = b'\x52'  # OP_2
    witness_script += b''.join(pubkeys)  # Public keys
    witness_script += b'\x53'  # OP_3
    witness_script += b'\xae'  # OP_CHECKMULTISIG
    print(f"111 {hexlify(witness_script)}")
    return witness_script

# Function to hash the witness script (SHA256)
def hash_witness_script(witness_script):
    # First, compute SHA256 hash of the witness script
    sha256_hash = hashlib.sha256(witness_script).digest()

    return sha256_hash


# Function to generate the P2WSH address from the witness script
def generate_p2wsh_address(witness_script):
    # Hash the witness script
    script_hash = hash_witness_script(witness_script)

    # Encode the script hash using Bech32 (for SegWit P2WSH)
    # We use the 'bc' prefix (for Bitcoin) and version 0 (for P2WSH)
    p2wsh_address = bech32.encode("bc", 0, script_hash)

    return p2wsh_address

# Create the witness script
witness_script = create_witness_script(sorted_xpubs)

# Generate the P2WSH address
p2wsh_address = generate_p2wsh_address(witness_script)

# Print the result
print("Generated P2WSH SegWit Address:", p2wsh_address)

I got: Generated P2WSH SegWit Address: bc1qgj3jyxugxm62whrzn7r6xrf7wtejzh2yxlv2cuzumltzpel9dcsssngq8t

When I checked with wallets like Sparrow or Specter, it should be bc1q6rplrk6ykcrgwdh5shq78jhlupcpua5hed4jx4hahkljt0gwgwys8gyzp9

Could anyone point missing bits in the code?

Cheers



from Recent Questions - Bitcoin Stack Exchange https://ift.tt/qYShDaK
via IFTTT

Popular posts from this blog

Crypto Exec Warns Tokenization Is Moving Faster Than Expected

Image
According to a post shared on X by Keith Grossman, president of crypto payments firm MoonPay, finance is heading toward an onchain future that could unfold over several years. The view comes as large banks and asset managers begin product tokenization, a move that once seemed extreme but is now being treated as a practical step by major institutions. Regulatory Signals Push Institutions Forward Based on reports cited by Grossman, progress has accelerated because rules are becoming clearer. Legislative efforts, regulatory guidance, bank involvement and accounting standards are starting to line up. That combination reduces uncertainty, which is often what slows large pools of capital. BlackRock has already launched tokenized funds, while Franklin Templeton is running tokenized money market funds on public blockchains. Those actions suggest that tokenization is no longer confined to pilot labs or internal trials. It is being used with real assets and real clients. Bank of Ameri...
Read more

Bitcoin Mining Could Be Strengthening The Ruble, Russian Central Bank Says

Image
Bitcoin mining may be providing incremental support to the Russian ruble, Central Bank Governor Elvira Nabiullina said, while cautioning that the effect is difficult to measure because much of the sector still operates in a legal and reporting gray zone. Bitcoin Mining May Support The Ruble Responding to a question at a press conference, Nabiullina said it is “probably difficult to quantify” mining’s influence “because a significant part of mining is still in a gray area.” Still, she added that mining is “indeed one of the additional factors contributing to the strong ruble exchange rate.” As Russian business news portal for RBC reported , her remarks come as Russian officials increasingly frame mining and crypto flows as macro-relevant, not just a niche tech or energy story. Earlier, Maxim Oreshkin, deputy head of the presidential administration, said ruble forecasts have been thrown off by the underestimation of financial flows tied to mining and cryptocurrency. In his view, the s...
Read more

Nigerian SEC Partners With Police To Tackle Crypto Ponzi Schemes – Details

Image
The Nigerian Securities and Exchange Commission (SEC) is maintaining an intense focus on the local cryptocurrency industry, as indicated by recent developments. While introducing minimum capital requirements for previously unregulated virtual asset service providers (VASPs), the securities regulator has also formed an alliance with the Nigeria Police Force (NPF) against cryptocurrency fraud, among other illegal operations. Nigerian SEC Looks To Improve Crypto Investors’ Protection According to local media Voice of Nigeria , the SEC is ramping up efforts aimed at investor protection and transparent market operations in the crypto ecosystem. In a recent meeting with the NPF, the Commission’s Director-General (DG), Dr. Emomotimi Agama, communicated to the Inspector General of Police (IGP), Kayode Egbetokun, concerns over malicious actors in the financial markets who exploit investors’ trust for personal gains.  Dr. Agama said: They cloak their deceit in the glamorous but misunder...
Read more